Програмиране с Rust

Курс във Факултета по Математика и Информатика към СУ

Решение на Сметки с ДНК от Наделина Шипочка

Обратно към всички решения

Към профила на Наделина Шипочка

Резултати

  • 17 точки от тестове
  • 0 бонус точки
  • 17 точки общо
  • 10 успешни тест(а)
  • 2 неуспешни тест(а)

Код

pub struct NucleotideCounter {
pub a: usize,
pub c: usize,
pub g: usize,
pub t: usize,
}
pub fn counts(dna: &[char]) -> NucleotideCounter {
//We create counters for each character we can encounter
let mut a_cnt = 0;
let mut c_cnt = 0;
let mut g_cnt = 0;
let mut t_cnt = 0;
//We count them in the slice
for character in dna.iter(){
match *character{
'A' => a_cnt += 1,
'C' => c_cnt += 1,
'G' => g_cnt += 1,
'T' => t_cnt += 1,
_ => panic!("Oops!")
}
}
//We return a struct with the values
NucleotideCounter{a: a_cnt, c: c_cnt, g: g_cnt, t: t_cnt}
}
pub fn dna_complement(dna: &[char]) -> Vec<char> {
let a_complement: char = 'T';
let c_complement: char = 'G';
let g_complement: char = 'C';
let t_complement: char = 'A';
let mut complement = Vec::new();
for character in dna.iter(){
match *character{
'A' => complement.push(a_complement),
'C' => complement.push(c_complement),
'G' => complement.push(g_complement),
'T' => complement.push(t_complement),
_ => panic!("Oops!")
}
}
complement
}
pub fn reverse_rna_complement(dna: &[char]) -> Vec<char> {
let a_complement: char = 'U';
let c_complement: char = 'G';
let g_complement: char = 'C';
let u_complement: char = 'A';
let mut complement = Vec::new();
for character in dna.iter().rev(){
match *character{
'A' => complement.push(a_complement),
'C' => complement.push(c_complement),
'G' => complement.push(g_complement),
'U' => complement.push(u_complement),
_ => panic!("Oops!")
}
}
complement
}

Лог от изпълнението

Compiling solution v0.1.0 (/tmp/d20220112-2706256-xbiuav/solution)
    Finished test [unoptimized + debuginfo] target(s) in 5.56s
     Running tests/solution_test.rs (target/debug/deps/solution_test-4c880d3f0adaac34)

running 12 tests
test solution_test::test_counts_basic ... ok
test solution_test::test_counts_big ... ok
test solution_test::test_counts_panic1 - should panic ... ok
test solution_test::test_counts_panic2 - should panic ... ok
test solution_test::test_counts_zero ... ok
test solution_test::test_dna_complement_big ... ok
test solution_test::test_dna_complement_empty ... ok
test solution_test::test_dna_complement_panic - should panic ... ok
test solution_test::test_reverse_rna_complement_big ... FAILED
test solution_test::test_reverse_rna_complement_empty ... ok
test solution_test::test_reverse_rna_complement_panic1 - should panic ... ok
test solution_test::test_reverse_rna_complement_panic2 - should panic ... FAILED

failures:

---- solution_test::test_reverse_rna_complement_big stdout ----
thread 'main' panicked at 'Oops!', src/lib.rs:78:18

---- solution_test::test_reverse_rna_complement_panic2 stdout ----
note: test did not panic as expected

failures:
    solution_test::test_reverse_rna_complement_big
    solution_test::test_reverse_rna_complement_panic2

test result: FAILED. 10 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

error: test failed, to rerun pass '--test solution_test'

История (2 версии и 1 коментар)

Наделина качи първо решение на 20.10.2021 15:27 (преди почти 4 години)

Наделина качи решение на 24.10.2021 20:28 (преди почти 4 години)

pub struct NucleotideCounter {
pub a: usize,
pub c: usize,
pub g: usize,
pub t: usize,
}
pub fn counts(dna: &[char]) -> NucleotideCounter {
//We create counters for each character we can encounter
let mut a_cnt = 0;
let mut c_cnt = 0;
let mut g_cnt = 0;
let mut t_cnt = 0;
//We count them in the slice
- for character in dna{
+ for character in dna.iter(){
match *character{
'A' => a_cnt += 1,
'C' => c_cnt += 1,
'G' => g_cnt += 1,
'T' => t_cnt += 1,
_ => panic!("Oops!")
}
}
//We return a struct with the values
- return NucleotideCounter{a: a_cnt, c: c_cnt, g: g_cnt, t: t_cnt};
+ NucleotideCounter{a: a_cnt, c: c_cnt, g: g_cnt, t: t_cnt}
}
pub fn dna_complement(dna: &[char]) -> Vec<char> {
let a_complement: char = 'T';
let c_complement: char = 'G';
let g_complement: char = 'C';
let t_complement: char = 'A';
let mut complement = Vec::new();
- for character in dna{
+ for character in dna.iter(){
match *character{
'A' => complement.push(a_complement),
'C' => complement.push(c_complement),
'G' => complement.push(g_complement),
'T' => complement.push(t_complement),
_ => panic!("Oops!")
}
}
- return complement;
+ complement
}
pub fn reverse_rna_complement(dna: &[char]) -> Vec<char> {
let a_complement: char = 'U';
let c_complement: char = 'G';
let g_complement: char = 'C';
let u_complement: char = 'A';
let mut complement = Vec::new();
for character in dna.iter().rev(){
match *character{
'A' => complement.push(a_complement),
'C' => complement.push(c_complement),
'G' => complement.push(g_complement),
'U' => complement.push(u_complement),
_ => panic!("Oops!")
}
}
- return complement;
+ complement
}

Разумно решение, отвъд проблема с входната валидация на последната функция. Бих обмислил дали си заслужава отделни променливи за counter-ите, a_cnt, g_cnt, etc, предвид че може да си инстанцираш един counter, и да го мутираш в цикъла (така или иначе правиш мутация, дали е на числови променливи или на counter, няма голямо значение в случая). Откъм именуване също е добра идея вектори и подобни колекции да бъдат в множествено число. Името a_complement е в единствено число, защото е един char. Вектора с резултата има повече смисъл да се казва "complements".